Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved WatchManager.js from WatchKeeper #283

Merged
merged 9 commits into from
Oct 12, 2022
Merged

Moved WatchManager.js from WatchKeeper #283

merged 9 commits into from
Oct 12, 2022

Conversation

nathanholzworth
Copy link
Contributor

Moved WatchManager.js from WatchKeeper to Kubernetes-utils to make it available to other razee projects and updated it slightly to reflect its new location.

adamkingit
adamkingit requested changes Sep 16, 2022
View reviewed changes
Copy link
Contributor

@adamkingit adamkingit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to add the new function to the exports to use it outside the kubernetes-util package

adamkingit
adamkingit reviewed Sep 28, 2022
View reviewed changes
lib/WatchManager.js Outdated Show resolved Hide resolved
adamkingit
adamkingit reviewed Sep 28, 2022
View reviewed changes
lib/WatchManager.js Outdated Show resolved Hide resolved
adamkingit
adamkingit requested changes Sep 28, 2022
View reviewed changes
Copy link
Contributor

@adamkingit adamkingit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest changing let to const wherever possible, and replacing all uses of var with let or const as appropriate

@nathanholzworth nathanholzworth merged commit 78c6a36 into master Oct 12, 2022
@nathanholzworth nathanholzworth deleted the add-watchmanager branch October 12, 2022 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamkingit adamkingit adamkingit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nathanholzworth @adamkingit