chore(eventhandler): include options object in event handler #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes a common options object to be passed into the event handler constructor and propogated through its factory function. This makes adding additional customer properties and configration easier to manage between the various repos and minimizes the need to explicitly expose option in every project
|
Is there a way to re-trigger this build? |
|
i think you just have to push an empty commit |
|
@alewitt2 done |
Looks like there may be a change to the LIBC version on node18 that travis isn't ready for
alewitt2
reviewed
Nov 2, 2022
Co-authored-by: Alex Lewitt <48691328+alewitt2@users.noreply.github.com>
|
@alewitt2 Seems like the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes a common options object to be passed into the event handler constructor and propogated through its factory function.
This makes adding additional customer properties and configration easier to manage between the various repos and minimizes the need to explicitly expose option in every project