Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking: Enable GraphQL by default #360

Merged
merged 49 commits into from
Jun 8, 2020
Merged

Breaking: Enable GraphQL by default #360

merged 49 commits into from
Jun 8, 2020

Conversation

dalehille
Copy link
Contributor

@dalehille dalehille commented May 27, 2020 •
edited
Loading

  • turn on graphql by default
  • use graphql endpoints for channel/subscription updates
  • use default auth_model for graphql connections ( razee-org-key or x-api-key)
  • add channel/subscription graphql subscriptionsByTag and gql subscription
  • remove api/v1/cluster and /api/v1/subscription endpoints (except for GET /api/v1/channels/:channelName/:versionId)

dalehille and others added 30 commits April 22, 2020 15:14
@dalehille
WIP
f386373
@dalehille
WIP
2246215
@dalehille
add subscriptionsByTag query. have the sub send back true if somethin…
64caa7d 
…g was updaetd for an org id
@dalehille
remove comments
81aa625
@dalehille
don't require tags on the subscriptionUpdated subscription
cdf9f3b
@dalehille
add tests for subscriptionsByTag
bb87a51
@dalehille
subscription tests
94ed3a3
@dalehille
removing subscriptionsSubs.spec for now
667d333
@yingwang-us
update
f259b0f
@yingwang-us
mock redis
0cbbb60
@dalehille
throw a proper graphql error instead of returning an empty array
130cc65
@rmgraham
Merge branch 'master' of github.com:razee-io/Razeedash-api into clust…
91ba2a5 
…er_subscription_gql
@rmgraham
added userToken functionality
516e075
@rmgraham
Merge branch 'master' of github.com:razee-io/Razeedash-api into clust…
53bd5ca 
…er_subscription_gql
@rmgraham
Merge branch 'cluster_subscription_gql' of github.com:razee-io/Razeed…
b15090c 
…ash-api into cluster_subscription_gql_user_token
@dalehille
lint fixes. update owner field on add subscription
c8ef72b
@dalehille
temporarily disabling apollo tests so we can get an image built
dfa55fc
@rmgraham
only used userToken in db for request
d174bbe
@rmgraham
eslint
4a67c64
@dalehille
Merge pull request #334 from razee-io/cluster_subscription_gql_user_t…
09be8e4 
…oken

Cluster subscription gql user token
@dalehille
Merge branch 'master' of https://github.com/razee-io/razeedash-api in…
00c6fc1 
…to cluster_subscription_gql
@dalehille
wip
931ca60
@rmgraham
fixed websockets not working
4aafcc0
@dalehille
add orgId to the context
b567469
@dalehille
remove unused import
4684e48
@dalehille
enable grapql. remove socket.io code
09cf9c9
@dalehille
update userToken auth
f129e50
@dalehille
enable websocket keepAlive for subscriptions
e48c25f
@dalehille
debugging
7919308
@dalehille
add REDIS_PUBSUB_URL env variable. remove logs. remove old pubsub code
5da2004
@nathanleviere nathanleviere marked this pull request as draft May 27, 2020 17:43
@dalehille dalehille requested a review from mckaymic May 29, 2020 08:57
yingwang-us
yingwang-us suggested changes Jun 2, 2020
View reviewed changes
app/apollo/resolvers/organization.js Outdated Show resolved Hide resolved
app/apollo/resolvers/common.js Outdated Show resolved Hide resolved
@dalehille dalehille changed the title Cluster subscription graphql Breaking: Enable GraphQL by default Jun 4, 2020
@dalehille dalehille marked this pull request as ready for review June 4, 2020 14:35
@dalehille dalehille mentioned this pull request Jun 4, 2020
Merged
yingwang-us
yingwang-us approved these changes Jun 5, 2020
View reviewed changes
Copy link
Contributor

@yingwang-us yingwang-us left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dalehille dalehille merged commit 290933f into master Jun 8, 2020
@dalehille dalehille deleted the cluster_subscription_gql branch June 8, 2020 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yingwang-us yingwang-us yingwang-us approved these changes

@mckaymic mckaymic Awaiting requested review from mckaymic

@rmgraham rmgraham Awaiting requested review from rmgraham

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dalehille @yingwang-us @rmgraham