Skip to content
This repository was archived by the owner on Nov 14, 2023. It is now read-only.

RudderStack Analytics Integration with HyperTrace #27

Merged
merged 274 commits into from
Apr 6, 2022
Merged

RudderStack Analytics Integration with HyperTrace #27

merged 274 commits into from
Apr 6, 2022

Conversation

jaywalker21
Copy link

  • This PR introduces a mechanism to manage secrets for HT UI.
  • It also adds support for RudderStack Analytics in the application.

jake-bassett and others added 30 commits November 9, 2021 15:54
@jake-bassett
feat: hide header divider line when in detail list mode (hypertrace#1246
bba10d4 
)
@anandtiwary
feat: add additional specification array to entity spec (hypertrace#1247
586da92 
)

* feat: add additional specification array to entity spec

* refactor: fixing test

* refactor: fix test

* refactor: fix test

* refactor: fix test

* refactor: fix test again
@aaron-steinfeld
fix: make explorer content scrollable (hypertrace#1248)
0d793a2
@palbizu
feat: import filter url service (hypertrace#1251)
0eff64f 
Co-authored-by: Patricio Albizu <patricioalbizu@Patricios-MacBook-Pro.local>
@jake-bassett
fix: make divider 1px high (hypertrace#1253)
a9293f3
@anandtiwary
refactor: breadcrumb to support additional specifications (hypertrace…
b1d8250 
…#1254)

* refactor: breadcrumb to support additional specifications

* refactor: fixing lint

* refactor: fix test

* refactor: addressing review comments

* refactor: fixing test

* refactor: fixing lint

* refactor: addressing review comments

* refactor: fixing test

* refactor: update breadcrumb and fix tests
@aaron-steinfeld
feat: persist explorer state in url (hypertrace#1257)
e9cdabe
@dependabot
chore:(deps): bump core-js from 3.19.0 to 3.19.1 (hypertrace#1261)
756d8f4
@dependabot
chore:(deps-dev): bump @commitlint/config-conventional (hypertrace#1260)
2f4c2b3
@dependabot
chore:(deps): bump mixpanel-browser from 2.41.0 to 2.42.0 (hypertrace…
6bc351d 
…#1259)
@dependabot
chore:(deps): bump @apollo/client from 3.4.16 to 3.4.17 (hypertrace#1263
5ee7d10 
)
@palbizu
feat: Adding properties to Title Content (hypertrace#1235)
7013af5 
* feat: Adding properties to Title Content

* feat: Fixing comments

* feat: fixing comments

Co-authored-by: Patricio Albizu <patricioalbizu@Patricios-MacBook-Pro.local>
@arjunlalb
fix: common project should not depend on components project (hypertra…
3cc0402 
…ce#1264)

* fix: common project should not depend on components project
@snyk-bot
fix: upgrade graphql from 15.6.1 to 15.7.0 (hypertrace#1266)
c601819 
Snyk has created this PR to upgrade graphql from 15.6.1 to 15.7.0.

See this package in npm:
https://www.npmjs.com/package/graphql

See this project in Snyk:
https://app.snyk.io/org/surajpuvvada/project/553e7174-0e22-4c7f-aa2c-12ae5f5768b5?utm_source=github&utm_medium=referral&page=upgrade-pr
@itssharmasandeep
feat: adding loading config functionality to table view toggle widget (…
21247f9 
…hypertrace#1267)
@jake-bassett
Table use local storage for columns (hypertrace#1265)
6803f3b 
* feat: use local storage to persist table columns

* fix: typo

* style: lint

* style: prettier
@aaron-steinfeld
fix: avoid dupe columns, clear group name from url on none (hypertrac…
612c72a 
…e#1269)
@arjunlalb
feat: util methods to manipulate graphqlTimeRange (hypertrace#1271)
e14d879 
* feat: util methods to manipulate graphqlTimeRange
@dependabot
chore:(deps-dev): bump husky from 7.0.1 to 7.0.4 (hypertrace#1276)
011cda2
@dependabot
chore:(deps-dev): bump @commitlint/cli from 13.1.0 to 15.0.0 (hypertr…
b9eefdb 
…ace#1274)
@dependabot
chore:(deps-dev): bump ts-node from 10.2.1 to 10.4.0 (hypertrace#1277)
0236f33
@snyk-bot
fix: upgrade graphql from 15.7.0 to 15.7.2 (hypertrace#1280)
6908d7f 
Snyk has created this PR to upgrade graphql from 15.7.0 to 15.7.2.

See this package in npm:
https://www.npmjs.com/package/graphql

See this project in Snyk:
https://app.snyk.io/org/saxenakshitiz/project/f89d1009-f321-4082-a83b-34ae0ca070eb?utm_source=github&utm_medium=referral&page=upgrade-pr
@arjunlalb
fix: new style for title in titled content (hypertrace#1283)
965c0c2 
* fix: new style for title in titled content
@aaron-steinfeld
fix: emit correct shape for single select change (hypertrace#1284)
f042275
@aaron-steinfeld
feat: change default visualization for spans to count (hypertrace#1272)
70f6e9a
@jake-bassett
feat: add styling to table filters with applied values (hypertrace#1285)
b35921e
@arjunlalb
fix: support for custom row size for table (hypertrace#1286)
11f2a78
@dependabot
chore:(deps-dev): bump @types/node from 16.7.10 to 16.11.10 (hypertra…
dd933a7 
…ce#1289)
@dependabot
chore:(deps-dev): bump jest-config from 27.3.1 to 27.4.0 (hypertrace#…
7870e97 
…1292)
@dependabot
chore:(deps): bump @apollo/client from 3.4.17 to 3.5.5 (hypertrace#1291)
aa91526
@jaywalker21 jaywalker21 self-assigned this Apr 5, 2022
@github-actions

This comment has been minimized.

Sign in to view
Sunn-y-Arora
Sunn-y-Arora reviewed Apr 6, 2022
View reviewed changes
copy-secrets.sh Outdated
@@ -0,0 +1,3 @@
touch secrets.js
echo "window.RUDDERSTACK_HT_WRITE_KEY = \"$RUDDERSTACK_HT_WRITE_KEY\";" > secrets.js
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 case, secret not found what will happen then.
eg -> in perf/devstack we wont be adding this rigth, so u want to add dummy values in secret or handle it in code
(best would be to add dummy, so code remains same)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a way to first check if analytics(rudderstack) is enabled and then execute this. Else, for those who don't want this, it might end up failing.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will add the feature flag kinda stuff so it can be dynamically enabled and disabled.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added feature flag for analytics

cseas
cseas approved these changes Apr 6, 2022
View reviewed changes
Copy link

@cseas cseas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left minor suggestions.

@github-actions

This comment has been minimized.

Sign in to view
@jaywalker21 jaywalker21 merged commit 6f64b89 into rzp_main Apr 6, 2022
@jaywalker21 jaywalker21 deleted the feature/analytics-integration branch April 6, 2022 09:11
@github-actions
Copy link

github-actions bot commented Apr 6, 2022

Unit Test Results

       4 files  ±0     289 suites  ±0   20m 32s ⏱️ - 3m 54s
1 040 tests ±0  1 040 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
1 048 runs  ±0  1 048 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 6f64b89. ± Comparison against base commit 7c4c1cd.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@suddendust suddendust Awaiting requested review from suddendust

@Sunn-y-Arora Sunn-y-Arora Awaiting requested review from Sunn-y-Arora

@venkatvghub venkatvghub Awaiting requested review from venkatvghub

@akashmane1598 akashmane1598 Awaiting requested review from akashmane1598

1 more reviewer

@cseas cseas cseas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jaywalker21 jaywalker21

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.