Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated changelog.md #322

Merged
merged 6 commits into from
Nov 24, 2022
Merged

Updated changelog.md #322

merged 6 commits into from
Nov 24, 2022

Conversation

ankitdas13
Copy link
Contributor

Patch Changes

  • Close virtualaccount end point [3e6daf3]:
  • passing partial_payment boolean issue when creating order [653a278]:

@ankitdas13 ankitdas13 requested a review from sidag95 November 16, 2022 11:51
Copy link

@sidag95 sidag95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CHANGELOG.md Outdated
- [Bugfix]: fix: passing `partial_payment` boolean issue when creating order [#311]
- Added Issue and feature templates
### Patch Changes
- Close virtualaccount end point \[[`3e6daf3`](https://github.com/razorpay/razorpay-node/commit/3e6daf3c555f62eb23660a54eaae756e395ea3b6)]:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion:

  • Fixed virtualAccount.close function implementation

  • Fixed orders.create function by passing partial_payment boolean

Copy link
Contributor Author

@ankitdas13 ankitdas13 Nov 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made these changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets start tagging who made these changes. Like how FE-universe or Blade does.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#310 3e6daf3 : Thanks @ankitdas13 ! - Fixed virtualAccount.close function implementation

#311 653a278: Thanks @ankitdas13 ! - Fixed orders.create function by passing partial_payment boolean

@kkyusufk @sidag95 is it looking good now ?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ankitdas13 Sure, please update the changelog with the above, will approve

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sidag95 It's done. Can you please approve?

@ankitdas13 ankitdas13 requested a review from sidag95 November 16, 2022 12:13
CHANGELOG.md Outdated
- Added Issue and feature templates
## 2.8.4 - 2022-11-21

- [#310](https://github.com/razorpay/razorpay-node/pull/310) [`3e6daf3`](https://github.com/razorpay/razorpay-node/commit/3e6daf3c555f62eb23660a54eaae756e395ea3b6) : Thanks [@ankitdas13 ](https://github.com/snitin315)! - Fixed `virtualAccount.close` function implementation
Copy link

@sidag95 sidag95 Nov 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion:@ankitdas13 Please update Thanks [@ankitdas13 ](https://github.com/snitin315)! with your github account link 😅

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sidag95 sorry i didnt saw that 😅 . i have updated the account link

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ankitdas13 Last thing, why an extra space after @ankitdas13?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sidag95
With space @ankitdas13 !
Without space @ankitdas13!

Should i remove space ?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, lets remove it

@ankitdas13 ankitdas13 requested a review from sidag95 November 21, 2022 12:14
Copy link

@sidag95 sidag95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ankitdas13 ankitdas13 merged commit c992906 into master Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants