Improves javascript structure #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
captn3m0
commented
Jun 5, 2017
captn3m0
commented
- Uses wp_enqueue_script and wp_localize_script
razorpay-payments.php
Outdated
| <script> | ||
| var data = $json; | ||
| </script> | ||
| wp_enqueue_script('razorpay_wc_script', plugin_dir_url(__FILE__) . 'script.js', |
There was a problem hiding this comment.
@captn3m0 Shouldn't we register the script first and then enqueue it?
http://www.wpbeginner.com/wp-tutorials/how-to-properly-add-javascripts-and-styles-in-wordpress/
There was a problem hiding this comment.
I copied this from gf plugin, I think. will check and fix
razorpay-payments.php
Outdated
| 'https://checkout.razorpay.com/v1/checkout.js', | ||
| null, null); | ||
|
|
||
| wp_enqueue_script('razorpay_wc_script'); |
There was a problem hiding this comment.
@captn3m0 Why enqueue the script twice?
razorpay-payments.php
Outdated
| $data | ||
| ); | ||
|
|
||
| wp_register_script('razorpay_checkout', |
There was a problem hiding this comment.
Shouldn't we register this script before razorpay_wc_script in order for the steps to be in the right logical order, even though they don't necessarily have to be in that order for it to work?
| <form name='razorpayform' action="$redirectUrl" method="POST"> | ||
| <input type="hidden" name="razorpay_payment_id" id="razorpay_payment_id"> | ||
| <input type="hidden" name="razorpay_signature" id="razorpay_signature" > | ||
| <!-- This distinguishes all our various wordpress plugins --> | ||
| <input type="hidden" name="razorpay_wc_form_submit" value="1"> |
added 2 commits
June 6, 2017 13:53
- Uses wp_enqueue_script and wp_localize_script
mayankamencherla
approved these changes
Jun 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.