Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sugestion/Request: Signature of symbol in documentSymbol #42

Open
joefbkohler opened this issue Aug 15, 2022 · 9 comments
Open

Sugestion/Request: Signature of symbol in documentSymbol #42

joefbkohler opened this issue Aug 15, 2022 · 9 comments

Comments

@joefbkohler
Copy link

Workspace Symbol works perfectly by showing the signature, but Document Symbol doesn't. It can be confusing because of methods overloads, so it would be nice if the Name of the symbol included the signature.

razzmatazz added a commit that referenced this issue Aug 18, 2022
…sponse

..similarly like we do with symbol info-on-hover

Related to issue "Sugestion/Request: Signature of symbol in
documentSymbol" (#42)
@razzmatazz
Copy link
Owner

should be fixed as of b2c920c

will release a new version some time later

@razzmatazz
Copy link
Owner

https://www.nuget.org/packages/csharp-ls/0.5.4 has been released that should fix the issue

@joefbkohler
Copy link
Author

It did :) but it seems to have a character limit that crops long namespaces/methods/signatures.

@razzmatazz
Copy link
Owner

mhm.. you mean on emacs?

it does it for me too, I think this is autocompletion framework (are you using ivy too?) restriction :/

because I see the full type going on the wire, will need to investigate, lets see if there are any tunables..

@razzmatazz
Copy link
Owner

razzmatazz commented Aug 30, 2022

or it could be lsp-mode.. as I can't see any tunables for ivy that restrict the length of the item at first glance

@joefbkohler
Copy link
Author

joefbkohler commented Aug 30, 2022

Yeah, I'm using Ivy. But it works with long signatures in Workspce Symbol, References, etc...

@razzmatazz
Copy link
Owner

razzmatazz commented Sep 5, 2022

same thing for me.. I probably need to investigate what it is that truncates the text, deeper in lsp-mode

@razzmatazz
Copy link
Owner

razzmatazz commented Sep 13, 2022

It did :) but it seems to have a character limit that crops long namespaces/methods/signatures.

found the problem, at least on my emacs configuration imenu-max-item-length is set to 60; now I set it to 200 and things look ok for now:

(setq imenu-max-item-length 200)

at one point I was thinking about adding a function to lsp-ivy.el, but maybe not now:

@razzmatazz
Copy link
Owner

btw, I am still working on documentSymbol to expose more information on items and hierarchical structure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants