Allow predefining targets at startup #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use of spf13/cobra for command line parsing - Moved actual proxying code to own package - Added golangci config - Upgraded golang version to 1.16 Signed-off-by: Jeroen van Erp <jeroen@hierynomus.com>
- Split up code over several structs - Improved cleanup/shutdown logic - Added flag to start with set of mirrors configured Signed-off-by: Jeroen van Erp <jeroen@hierynomus.com>
Signed-off-by: Jeroen van Erp <jeroen@hierynomus.com>
rb3ckers
reviewed
Aug 30, 2021
cmd/root.go
Outdated
| cmd.Flags().String("password", "", "Provide a file that contains username/password to protect the configuration 'targets' endpoint. Contains 1 username/password combination separated by ':'.") | ||
| cmd.Flags().Int("fail-after", 30, "Remove a target when it has been failing for this many minutes.") //nolint:gomnd | ||
| cmd.Flags().Int("retry-after", 1, "After 5 successive failures a target is temporarily disabled, it will be retried after this many minutes.") | ||
| cmd.Flags().StringSlice("mirror", []string{}, "Mirror traffic to additional targets") |
There was a problem hiding this comment.
I prefer to rephrase this to something like "Start with mirroring to these targets"
rb3ckers
reviewed
Aug 30, 2021
| "github.com/stretchr/testify/assert" | ||
| ) | ||
|
|
||
| func TestReflector(t *testing.T) { |
|
Thanks for the refactoring. The code looks a lot cleaner now tbh. |
rb3ckers
changed the title
|
Note that these pre-configured targets may still disappear from the targets list right now when they are offline for more than the configured time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.