Clickable otpauth Link, fixes #66

rbCAS · Feb 8, 2015 · a61a3bf · a61a3bf
1 parent 657a66c
commit a61a3bf
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 4 deletions.
diff --git a/app/controllers/casino/two_factor_authenticators_controller.rb b/app/controllers/casino/two_factor_authenticators_controller.rb
@@ -2,6 +2,7 @@
 
 class CASino::TwoFactorAuthenticatorsController < CASino::ApplicationController
   include CASino::SessionsHelper
+  include CASino::TwoFactorAuthenticatorsHelper
   include CASino::TwoFactorAuthenticatorProcessor
 
   before_action :ensure_signed_in

diff --git a/app/helpers/casino/two_factor_authenticators_helper.rb b/app/helpers/casino/two_factor_authenticators_helper.rb
@@ -0,0 +1,5 @@
+module CASino::TwoFactorAuthenticatorsHelper
+  def otp_auth_url(two_factor_authenticator)
+    "otpauth://totp/#{u CASino.config.frontend[:sso_name] + ': ' + two_factor_authenticator.user.username}?secret=#{two_factor_authenticator.secret}&issuer=#{u CASino.config.frontend[:sso_name]}"
+  end
+end
diff --git a/app/helpers/service_tickets_helper.rb b/app/helpers/service_tickets_helper.rb
diff --git a/app/views/casino/two_factor_authenticators/new.html.erb b/app/views/casino/two_factor_authenticators/new.html.erb
@@ -11,10 +11,13 @@
         <%= t('two_factor_authenticators.instructions') %>
       </p>
       <div id="qr-code">
-        <img src="https://chart.googleapis.com/chart?cht=qr&chs=250x250&chl=<%= u "otpauth://totp/#{u CASino.config.frontend[:sso_name] + ': ' + @two_factor_authenticator.user.username}?secret=#{@two_factor_authenticator.secret}&issuer=#{u CASino.config.frontend[:sso_name]}" %>" height="250" width="250"><br />
+        <img src="https://chart.googleapis.com/chart?cht=qr&chs=250x250&chl=<%= u otp_auth_url(@two_factor_authenticator) %>" height="250" width="250"><br />
       </div>
       <p id="secret">
-        <%= t('two_factor_authenticators.secret') %>: <%= @two_factor_authenticator.secret %>
+        <%= t('two_factor_authenticators.secret') %>:
+        <a href="<%= otp_auth_url(@two_factor_authenticator) %>">
+          <%= @two_factor_authenticator.secret %>
+        </a>
       </p>
     </div>