Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

Refactoring of Processor/Listener Pattern #57

Closed
5 tasks
pencil opened this issue Jul 29, 2014 · 3 comments
Closed
5 tasks

Refactoring of Processor/Listener Pattern #57

pencil opened this issue Jul 29, 2014 · 3 comments
Milestone

Comments

@pencil
Copy link
Member

pencil commented Jul 29, 2014

As mentioned here:

I think we should plan a major overhaul of the processor/listener approach we currently use. It's too complicated and not of much use since we merged CASino and CASinoCore.

Plan

  • Find possible approaches to encapsulate the CAS logic
  • Architectural decision
  • Implement new architecture
  • ???
  • Profit!
@pencil pencil mentioned this issue Jul 29, 2014
@plribeiro3000
Copy link
Contributor

The listeners encapsulate the same logic as the Rails Responder. The big plus by using Responder is the easy customizations of this behavior (user navigation, redirect and render) with a feature maintained in the rails core.
It would be far to easy to change the default behavior (from render to redirect) on some action without break any compatibility with the business logic (Processors).

@pencil
Copy link
Member Author

pencil commented Oct 23, 2014

I'm not sure how to implement the Responders you mentioned. Maybe you could take a look at #63 and post your thoughts there? 🍻

@pencil pencil closed this as completed Oct 23, 2014
@plribeiro3000
Copy link
Contributor

@pencil I will take a look this weekend. =)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants