Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

Fixed NameError #56

Merged
merged 1 commit into from
Jul 28, 2014
Merged

Fixed NameError #56

merged 1 commit into from
Jul 28, 2014

Conversation

plribeiro3000
Copy link
Contributor

The ROTP was being referenced without properly load. The require is
enough to fix the issue.

Backtrace:

NameError - uninitialized constant ROTP:
activesupport (4.1.4) lib/active_support/dependencies.rb:518:in load_missing_constant' activesupport (4.1.4) lib/active_support/dependencies.rb:180:inconst_missing'
() Users/paulo/.rvm/gems/ruby-2.1.2@auth/bundler/gems/CASino-a2ec29c1a104/app/processors/casino/processor_concern/two_factor_authenticators.rb:12:in validate_one_time_password' () Users/paulo/.rvm/gems/ruby-2.1.2@auth/bundler/gems/CASino-a2ec29c1a104/app/processors/casino/second_factor_authentication_acceptor_processor.rb:24:inprocess'
() Users/paulo/.rvm/gems/ruby-2.1.2@auth/bundler/gems/CASino-a2ec29c1a104/app/controllers/casino/sessions_controller.rb:30:in `validate_otp'

The ROTP was being referenced without properly load. The require is
enough to fix the issue.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.0%) when pulling 5f559f1 on zertico:fix_name_error into 23b005a on rbCAS:master.

pencil added a commit that referenced this pull request Jul 28, 2014
@pencil pencil merged commit e45118d into rbCAS:master Jul 28, 2014
@pencil
Copy link
Member

pencil commented Jul 28, 2014

Thank you!

@plribeiro3000 plribeiro3000 deleted the fix_name_error branch July 28, 2014 16:05
@plribeiro3000
Copy link
Contributor Author

👍

Is there any plannings to use Responder on the Controllers to make it possible to Change the render/ redirect behavior without the need of overwrite the actions?

@pencil
Copy link
Member

pencil commented Jul 28, 2014

Actually I'd like to do a big refactoring as I mentioned here but I don't have the time. Maybe later this year.

@plribeiro3000
Copy link
Contributor Author

Sure, Is there something i can help you? Maybe if you break it in smaller tasks. I would gadly help you out move from the processor/listener stuff to responder.

@pencil
Copy link
Member

pencil commented Jul 29, 2014

I made an issue. If you have an idea for a possible architecture, let me know. Cheers! 🍻

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants