Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(code)!: exclude global decorators by default #53

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

igvnv
Copy link
Contributor

@igvnv igvnv commented Dec 19, 2023

Introduces the omitCodeDecorators configuration option to fix the issue with adding unnecessary decorators to Playroom code.

Issue: #47

Copy link
Owner

@rbardini rbardini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, @igvnv! Just a couple comments:

README.md Outdated Show resolved Hide resolved
src/withGlobals.ts Outdated Show resolved Hide resolved
@rbardini rbardini linked an issue Dec 27, 2023 that may be closed by this pull request
@igvnv igvnv requested a review from rbardini January 3, 2024 10:38
@rbardini rbardini changed the title feat(): Use stories code without global decorators feat(code)!: exclude decorators by default Jan 9, 2024
@rbardini rbardini changed the title feat(code)!: exclude decorators by default feat(code)!: exclude global decorators by default Jan 9, 2024
@rbardini rbardini merged commit 3c1aa4c into rbardini:master Jan 9, 2024
4 checks passed
Copy link

🎉 This PR is included in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storybook v7 with addon v4 is injecting decorators into playroom code
3 participants