Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove request on IN_IGNORED event #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

marksteward
Copy link

Fix internal state when an IN_IGNORED event happens. This allows the user to decide what to do (whether to re-add the watch later, or simply note that it's gone away).

Fixes #2

@rbarrois
Copy link
Owner

Thanks!

I've just fixed issues on the master branch, you should be able to get a reliable build output now :)

The fix looks great, however since it's handling a specific bug I'd feel safer if we had a test to replicate that issue; would you have the time to write such a test?

@marksteward
Copy link
Author

marksteward commented Nov 5, 2018

Uff OK. Can you explain how https://github.com/rbarrois/aionotify/blob/b1aa58e/tests/test_usage.py#L161 works? It blows up for me:

  File ".../aionotify/tests/test_usage.py", line 161, in test_watch_unwatch
    yield from asyncio.sleep(0.1)
  File "/usr/lib/python3.5/asyncio/tasks.py", line 510, in sleep
    loop = events.get_event_loop()
  File "/usr/lib/python3.5/asyncio/events.py", line 632, in get_event_loop
    return get_event_loop_policy().get_event_loop()
  File ".../aionotify/.eggs/asynctest-0.12.2-py3.5.egg/asynctest/case.py", line 71, in get_event_loop
    raise AssertionError("TestCase.forbid_get_event_loop is True, "
AssertionError: TestCase.forbid_get_event_loop is True, asyncio.get_event_loop() must not be called

@marksteward
Copy link
Author

Is this test acceptable?

@Jc2k
Copy link

Jc2k commented Oct 17, 2019

@rbarrois any change of this being merged and included in a release? Both this and #3 would be very useful.

@spumer
Copy link

spumer commented Apr 23, 2020

@rbarrois ?

@rbarrois
Copy link
Owner

@spumer this project isn't very actively maintained, as you might have seen — I don't use it in any of my projects.

I may be able to spend some time updating it in the next future, but can't provide any guarantee.

Or I could open to more maintainers, I'll try to look into the history of past contributions for that.

@spumer
Copy link

spumer commented Apr 23, 2020

Good! Cause i start using this project and got all problems which has been fixed in PRs.
And thank you for response

@marksteward
Copy link
Author

Happy to help maintain.

@marksteward
Copy link
Author

@rbarrois any chance you could merge this PR or bless a fork and transfer the pypi project?

@marksteward
Copy link
Author

@rbarrois hi, just checking back on my open PRs. Is there anything I can do to unstick this?

@marksteward
Copy link
Author

Anyone know of any good forks of this repo or should I create one?

@spumer
Copy link

spumer commented Mar 2, 2024

Anyone know of any good forks of this repo or should I create one?

No. Only alternative project: https://github.com/absperf/asyncinotify/ , but I prefer aionotify because of the more user-friendly API (for my tasks)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't reinstall watch for recreated directory
4 participants