-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove request on IN_IGNORED event #6
base: master
Are you sure you want to change the base?
Conversation
Thanks! I've just fixed issues on the master branch, you should be able to get a reliable build output now :) The fix looks great, however since it's handling a specific bug I'd feel safer if we had a test to replicate that issue; would you have the time to write such a test? |
Uff OK. Can you explain how https://github.com/rbarrois/aionotify/blob/b1aa58e/tests/test_usage.py#L161 works? It blows up for me:
|
Is this test acceptable? |
@spumer this project isn't very actively maintained, as you might have seen — I don't use it in any of my projects. I may be able to spend some time updating it in the next future, but can't provide any guarantee. Or I could open to more maintainers, I'll try to look into the history of past contributions for that. |
Good! Cause i start using this project and got all problems which has been fixed in PRs. |
Happy to help maintain. |
@rbarrois any chance you could merge this PR or bless a fork and transfer the pypi project? |
@rbarrois hi, just checking back on my open PRs. Is there anything I can do to unstick this? |
Anyone know of any good forks of this repo or should I create one? |
No. Only alternative project: https://github.com/absperf/asyncinotify/ , but I prefer aionotify because of the more user-friendly API (for my tasks) |
Fix internal state when an IN_IGNORED event happens. This allows the user to decide what to do (whether to re-add the watch later, or simply note that it's gone away).
Fixes #2