Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: mismatch cert files due to docker cache #17

Merged
merged 1 commit into from
Dec 8, 2017
Merged

Fix: mismatch cert files due to docker cache #17

merged 1 commit into from
Dec 8, 2017

Conversation

harishanand95
Copy link
Contributor

  • Fixes build issues related to docker cache.
  • "ansible/ubuntu-ssh" docker image build will now use --no-cache option.
  • All other docker image build process will have cache disabled when copying certificate authority's signing pub file.
  • Fixes tomcat's update repo sign errors.
  • Updated tomcat's container image from ubuntu:14.04 to ubuntu:16.04.
  • locales are generated in the ubuntu-ssh with env set to en_US.UTF-8. (has to be tested on all containers, but this won't result in any new issues)
  • All files in config/certificate_authority/keys has been deleted. These files are generated during installation of middleware and are not required in the GitHub. Added .gitignore.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
This commit fixes the issues related to docker cache.
1. "ansible/ubuntu-ssh" docker image build will use
   --no-cache option.
2. Rest of the docker images build process will have
   cache disabled for copying certificate-authority's signing pub file.
3. Fixes tomcat's ubuntu:14.04 to ubuntu:16.04.
4. locales are generated in the ubuntu-ssh with env set to
   en_US.UTF-8
5. All files in certificate authority deleted. It is generated during
   installation and is not required in git. Added .gitignore for it.

Signed-off-by: Harish Anand <harishanand95@gmail.com>
@harishanand95 harishanand95 self-assigned this Dec 7, 2017
@harishanand95 harishanand95 merged commit d83c2da into rbccps-iisc:master Dec 8, 2017
Copy link
Contributor Author

@harishanand95 harishanand95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting CACHEBUST to the current time means that it will always be unique, and instructions after the ARG declaration in the Dockerfile won't be cached. Note that you can also build without specifying the CACHEBUST build-arg, which will cause it to use the default value of 1 and preserve the cache. This can be used to always check out fresh copies of git repos, pull latest SNAPSHOT dependencies, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant