Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CRuby security-fix releases 3.0.7, 3.1.5, 3.2.4, and 3.3.1 #2370

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Add CRuby security-fix releases 3.0.7, 3.1.5, 3.2.4, and 3.3.1 #2370

merged 1 commit into from
Apr 23, 2024

Conversation

@hsbt hsbt merged commit bbeeee1 into rbenv:master Apr 23, 2024
4 checks passed
@kpfleming kpfleming deleted the 2024-04-23-releases branch April 23, 2024 12:55
@colszowka
Copy link

Thanks @kpfleming @hsbt!

I have a short question - why are we going with OpenSSL 3.1.4 here specifically, instead of 3.1.5, or the newer 3.2 or 3.3 families? https://www.openssl.org/source/ lists 3.3.0 as the newest version, released ~2 weeks ago, with 3.1.5 released this january

@eregon
Copy link
Member

eregon commented Apr 25, 2024

Because

!TODO! copy openssl line from other release with the same major.minor version
and e.g.
install_package "openssl-3.1.4" "https://www.openssl.org/source/openssl-3.1.4.tar.gz#840af5366ab9b522bde525826be3ef0fb0af81c6a9ebd84caa600fea1731eee3" openssl --if needs_openssl:1.0.2-3.x.x

In general OpenSSL versions are updated in their own PR (and there is https://github.com/rbenv/ruby-build/blob/master/script/update-openssl)

@eregon
Copy link
Member

eregon commented Apr 25, 2024

IOW, please make a PR if you'd like to update openssl ;)

@colszowka
Copy link

@eregon Got it, thanks! I'm not sure though which version to go with, is it safe to go all the way to 3.3.0 from 3.1.4, or just 3.1.5? I'm not familiar with the versioning policies and compatibility of OpenSSL

@mislav mislav mentioned this pull request May 1, 2024
@mislav
Copy link
Member

mislav commented May 1, 2024

@colszowka Thanks for pinging about this. I'm making a PR to upgrade to openssl 3.1.5.

why are we going with OpenSSL 3.1.4 here specifically, instead of 3.1.5, or the newer 3.2 or 3.3 families?

We could also update our Ruby build formulae to depend on OpenSSL 3.2 or 3.3, but since we've been depending on OpenSSL 3.1.x for a while now and since that branch is still maintained by the OpenSSL team, my vote is to stick with the 3.1.x branch for as long as it's maintained or until there is a concrete need to upgrade to OpenSSL 3.2/3.3, e.g. to gain access to a newer feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants