Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip single quote from LDFLAGS and CPPFLAGS #441

Closed
wants to merge 1 commit into from

Conversation

hsbt
Copy link
Member

@hsbt hsbt commented Oct 27, 2013

To building 2.1.0-dev with ruby-build master happened build failure. It seems that LDFLAGS and CPPFLAGS contains wrong variables such as single quote.

PS: ruby-trunk checked these variables and stopped build process by ruby/ruby@3636f8c

@hsbt hsbt closed this in 0b52061 Oct 27, 2013
@mislav
Copy link
Member

mislav commented Oct 27, 2013

Thanks for fixing! I worry that this will break installing to paths that contain spaces, however. I'll look into ways of escaping those that Ruby trunk won't choke on.

@mislav
Copy link
Member

mislav commented Oct 27, 2013

I just tried and it doesn't seem that installing Rubies into paths with spaces ever worked, even with quoted values. Installing openssl aborts very quickly with cryptic errors. I tried escaping with single quotes, double quotes, backslash. So I guess we didn't lose anything with this change.

@mislav
Copy link
Member

mislav commented Oct 27, 2013

Whoops, seems like installing 2.1.0-dev still fails even after your fix is applied. The problem is a missing directory listed in LDFLAGS. I'm making a proper fix right now.

mislav added a commit that referenced this pull request Oct 27, 2013
The problem wasn't in quoting as per 0b52061, but in the fact that
Ruby trunk added a LDFLAGS checker that aborts if any of the paths
listed in it are missing:
ruby/ruby@3636f8c

This is probably a bug in Ruby, but for now a simple workaround is to
iterate through paths in LDFLAGS and ensure they exist.

References #441
@hsbt hsbt deleted the strip-quote-from-ldflags branch October 27, 2013 22:32
@hsbt
Copy link
Member Author

hsbt commented Oct 27, 2013

@mislav Thanks for your verification :octocat:

@gabocas
Copy link

gabocas commented Dec 11, 2013

Dear development team.

I still have this problem when I try to install the 2.1.0-dev version.

Thanks for your help

@mislav
Copy link
Member

mislav commented Dec 11, 2013

@gabocas I can't reproduce on Mac OS X 10.9. Please tell us your OS version and rbenv install --version (or ruby-build --version if you don't use rbenv)

@gabocas
Copy link

gabocas commented Dec 11, 2013

Thanks for your help. I have OS X 10.9 and my ruby-build version is 20130901.

@mislav
Copy link
Member

mislav commented Dec 11, 2013

@gabocas You're on an outdated release. The version which contains the fix is v20131028

@gabocas
Copy link

gabocas commented Dec 11, 2013

Thank you very much for your help and time and sorry for my dumb question. It worked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants