-
Notifications
You must be signed in to change notification settings - Fork 788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strip single quote from LDFLAGS and CPPFLAGS #441
Conversation
Thanks for fixing! I worry that this will break installing to paths that contain spaces, however. I'll look into ways of escaping those that Ruby trunk won't choke on. |
I just tried and it doesn't seem that installing Rubies into paths with spaces ever worked, even with quoted values. Installing openssl aborts very quickly with cryptic errors. I tried escaping with single quotes, double quotes, backslash. So I guess we didn't lose anything with this change. |
Whoops, seems like installing 2.1.0-dev still fails even after your fix is applied. The problem is a missing directory listed in LDFLAGS. I'm making a proper fix right now. |
The problem wasn't in quoting as per 0b52061, but in the fact that Ruby trunk added a LDFLAGS checker that aborts if any of the paths listed in it are missing: ruby/ruby@3636f8c This is probably a bug in Ruby, but for now a simple workaround is to iterate through paths in LDFLAGS and ensure they exist. References #441
@mislav Thanks for your verification |
Dear development team. I still have this problem when I try to install the 2.1.0-dev version. Thanks for your help |
@gabocas I can't reproduce on Mac OS X 10.9. Please tell us your OS version and |
Thanks for your help. I have OS X 10.9 and my ruby-build version is 20130901. |
@gabocas You're on an outdated release. The version which contains the fix is |
Thank you very much for your help and time and sorry for my dumb question. It worked. |
To building 2.1.0-dev with ruby-build master happened build failure. It seems that LDFLAGS and CPPFLAGS contains wrong variables such as single quote.
PS: ruby-trunk checked these variables and stopped build process by ruby/ruby@3636f8c