Fix incorrect early exit in fallback

rbuckton · Mar 29, 2024 · a0a0553 · a0a0553
1 parent 67ae05d
commit a0a0553
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/Reflect.ts b/Reflect.ts
@@ -1750,8 +1750,8 @@ namespace Reflect {
             const provider: MetadataProvider = {
                 isProviderFor(O, P) {
                     let metadataPropertySet = metadataOwner.get(O);
-                    if (!IsUndefined(metadataPropertySet)) {
-                        return metadataPropertySet.has(P);
+                    if (!IsUndefined(metadataPropertySet) && metadataPropertySet.has(P)) {
+                        return true;
                     }
                     if (getOwnMetadataKeys(O, P!).length) {
                         if (IsUndefined(metadataPropertySet)) {

diff --git a/ReflectLite.ts b/ReflectLite.ts
@@ -1710,8 +1710,8 @@ namespace Reflect {
             const provider: MetadataProvider = {
                 isProviderFor(O, P) {
                     let metadataPropertySet = metadataOwner.get(O);
-                    if (!IsUndefined(metadataPropertySet)) {
-                        return metadataPropertySet.has(P);
+                    if (!IsUndefined(metadataPropertySet) && metadataPropertySet.has(P)) {
+                        return true;
                     }
                     if (getOwnMetadataKeys(O, P!).length) {
                         if (IsUndefined(metadataPropertySet)) {

diff --git a/ReflectNoConflict.ts b/ReflectNoConflict.ts
@@ -1587,8 +1587,8 @@ function CreateFallbackProvider(reflect: typeof Reflect): MetadataProvider {
     const provider: MetadataProvider = {
         isProviderFor(O, P) {
             let metadataPropertySet = metadataOwner.get(O);
-            if (!IsUndefined(metadataPropertySet)) {
-                return metadataPropertySet.has(P);
+            if (!IsUndefined(metadataPropertySet) && metadataPropertySet.has(P)) {
+                return true;
             }
             if (getOwnMetadataKeys(O, P!).length) {
                 if (IsUndefined(metadataPropertySet)) {