Reimplement the string-manipulation functions to write to variables instead of stdout #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstead of stdout. This change allows us to avoid unnecessary command substitutions which are (relatively speaking) quite expensive. Although __bp_sanitize_string is only used during installation __bp_trim_whitespace is invoked in a loop in the critial path as part of __bp_preexec_invoke_exec. Eliminating these subshells will reduce bash-preexec's overhead. See dimo414/prompt.gem@9764cdb3 for another example of a similar change. Note: the printf -v syntax was added to Bash in v3.1: https://mywiki.wooledge.org/BashFAQ/061
|
Wow! Playing with a bit locally timing my prompt and its looking like ~2x faster. @dimo414 thank you for this change 🙏 🎉 Much appreciated! |
|
Nice! That's even better than I expected. Thanks for the quick review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows us to avoid unnecessary command substitutions which are (relatively speaking) quite expensive. Although
__bp_sanitize_stringis only used during installation__bp_trim_whitespaceis invoked in a loop in the critical path as part of__bp_preexec_invoke_exec. Eliminating these subshells will reduce bash-preexec's overhead.See dimo414/prompt.gem@9764cdb3 for another example of a similar change.
Note: the
printf -vsyntax was added to Bash in v3.1: https://mywiki.wooledge.org/BashFAQ/061