Remove saving prior trap in PROMPT_COMMAND with subshell #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This was causing crashes in cases where users were doing: export PROMPT_COMMAND="history -a; $PROMPT_COMMAND;" - Original description from contributor: $(trap -p DEBUG)" is launching a sub-shell, bash itself. So when people do "export PROMPT_COMMAND="history -a; $PROMPT_COMMAND;"", they export form the parent shell to subsequent sub-shells. And that creates the infinite loop, that eventually segfault bash.
|
LGTM |
|
I'm surprised that moving |
|
@dimo414 You're right that this has broken trap preservation, sorry to have disrupted this feature. I wanted to put this through to remove the bug from our thread with Loic. If you have a way to still preserve it, please submit a PR 👍 |
|
That's fine, the patch is just confusing since it leaves bits of the trap-preservation logic in place (e.g. there's no point setting I'll file a separate bug to try to restore it. |
lguelorget
added a commit
to lguelorget/bash-preexec
that referenced
this pull request
Oct 24, 2017
- Avoids infinite recursion with things like export PROMPT_COMMAND="history -a; $PROMPT_COMMAND" - Preserve trap DEBUG again: revert rcaloras#60
Merged
rcaloras
pushed a commit
that referenced
this pull request
Oct 27, 2017
* Update bash-preexec.sh - Avoids infinite recursion with things like export PROMPT_COMMAND="history -a; $PROMPT_COMMAND" - Preserve trap DEBUG again: revert #60 * Update bash-preexec.sh * Update bash-preexec.sh * Update bash-preexec.sh * Update bash-preexec.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing crashes in cases where users were doing:
export PROMPT_COMMAND="history -a; $PROMPT_COMMAND;"
Original description from contributor:
$(trap -p DEBUG)" is launching a sub-shell, bash itself. So when people do
"export PROMPT_COMMAND="history -a; $PROMPT_COMMAND;"", they export form the
parent shell to subsequent sub-shells. And that creates the infinite loop,
that eventually segfault bash.