Skip to content

Commit

Permalink
refactor: remove todos (#16)
Browse files Browse the repository at this point in the history
  • Loading branch information
rcasia authored May 6, 2024
1 parent a3480f5 commit 57eab5b
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 8 deletions.
3 changes: 0 additions & 3 deletions lua/neotest-bash/core/result_builder.lua
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,6 @@ function ResultBuilder.build_results(spec, result, tree)
local results = ResultList:new()
local is_file = string.match(spec.symbol, "_test.sh") ~= nil

-- TODO: as bashunit does not provide reporting yet,
-- we run tests running one command per test funtion
-- so we do not expect to find files as spec.symbol
if not is_file then
for _, node in tree:iter_nodes() do
local node_data = node:data()
Expand Down
1 change: 0 additions & 1 deletion lua/neotest-bash/core/root_finder.lua
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ SpecBuilder = {}
---@param dir string @Directory to treat as cwd
---@return string | nil @Absolute root dir of test suite
function SpecBuilder.findRoot(dir)
-- TODO: check what happens when it's a single file
local matchers = {
".git",
"lib",
Expand Down
2 changes: 1 addition & 1 deletion lua/neotest-bash/util/result_list.lua
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ ExitCode = {
}

local ResultList = {
-- TODO: needs to be static until bashunit provides reporting
-- needs to be static
_results = {},

new = function(self)
Expand Down
3 changes: 0 additions & 3 deletions tests/core/spec_builder_spec.lua
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ local function mock_args_tree(data)
end

describe("spec_builder", function()
-- TODO: pending until bashunit has reporting
pending("should run command for a test file", function()
-- given
local args = mock_args_tree({
Expand All @@ -48,7 +47,6 @@ describe("spec_builder", function()
assert.are.same(expected_spec, result)
end)

-- TODO: pending until bashunit has reporting
pending("should run command for a test function inside a test file", function()
-- given
local args = mock_args_tree({
Expand All @@ -73,7 +71,6 @@ describe("spec_builder", function()
assert.are.same(expected_spec, result)
end)

-- TODO: we run a list of commands until we have bashunit reporting
async.it("should run a list of commands from a tree node selection", function()
-- given
--
Expand Down

0 comments on commit 57eab5b

Please sign in to comment.