Skip to content

Commit

Permalink
fix(resolve_qualified_name): null pointer when package is empty (#167)
Browse files Browse the repository at this point in the history
Fix a null pointer when the test class has no package at all.

Example file:

```java
// file:  ExampleTest.java
class ExampleTest {
}
```

it should return **"ExampleTest"**
  • Loading branch information
saburto authored Nov 19, 2024
1 parent e1371c1 commit 43b4cf9
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 2 deletions.
6 changes: 4 additions & 2 deletions lua/neotest-java/util/resolve_qualified_name.lua
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,9 @@ local function resolve_qualified_name(filename)
((class_declaration (identifier) @target))
]]

local package_line = find_in_text(package_query, content)[1]
local package_lines = find_in_text(package_query, content)

local package_line = (package_lines and package_lines[1]) and (package_lines[1] .. ".") or ""
local names = find_in_text(class_name_query, content)

-- as there can be different class names
Expand All @@ -54,7 +56,7 @@ local function resolve_qualified_name(filename)
end
end

return package_line .. "." .. name
return package_line .. name
end

return resolve_qualified_name
6 changes: 6 additions & 0 deletions tests/util/resolve_qualified_name_spec.lua
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,12 @@ describe("resolve_qualified_name", function()
]],
expected = "com.example.ExampleTest",
},
{
input = [[
class ExampleTest {}
]],
expected = "ExampleTest",
},
}

for _, case in ipairs(testcases) do
Expand Down

0 comments on commit 43b4cf9

Please sign in to comment.