Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github integration: check for on-chain approval before merging a PR #21

Open
dckc opened this issue Oct 23, 2020 · 10 comments
Open

github integration: check for on-chain approval before merging a PR #21

dckc opened this issue Oct 23, 2020 · 10 comments
Labels
future rholang Stuff that involves rholang code

Comments

@dckc
Copy link
Contributor

dckc commented Oct 23, 2020

No description provided.

@Bill-Kunj
Copy link
Collaborator

@dckc @jimscarver
Should we be formalizing multi-sig?

@jimscarver
Copy link
Contributor

github does this well enough. I see no requirement to do this onchain at this time. Othere stuff is higher priority.

@dckc
Copy link
Contributor Author

dckc commented May 19, 2021

Low priority is a reason to exclude an issue from a milestone, but not to close it.

I still think this is worth pursuing, eventually.

@dckc dckc reopened this May 19, 2021
@dckc
Copy link
Contributor Author

dckc commented May 19, 2021

Should we be formalizing multi-sig?

We have formalized it. See WorkingGroup.rho.

@Bill-Kunj
Copy link
Collaborator

@dckc @jimscarver
So are we thinking about creating an interface (UI/UX) specific to rgov (using multisig) that would automatically do a github PR approval?

@Bill-Kunj
Copy link
Collaborator

@dckc @jimscarver
So are we thinking about creating an interface (UI/UX) specific to rgov (using multisig) that would automatically do a github PR approval?

@dckc @jimscarver @w2vy
We should at least discuss this thoroughly. It's a great idea/POC, but otherwise this issue is just taking up space.

@dckc
Copy link
Contributor Author

dckc commented Jun 10, 2021

Is space in any way scarce?

I use this issues list as a wish list for related ideas. If you prefer that I store the issue elsewhere, I can transfer it to a different repo. But I would find that off-putting and it would likely decrease my engagement in this project.

@Bill-Kunj
Copy link
Collaborator

Bill-Kunj commented Jun 11, 2021

Space is not scarce. RGOV is voluntary. So, at the risk of repeating myself:
#21 (comment)
@dckc @jimscarver @w2vy
We should at least discuss this thoroughly. It's a great idea/POC, but otherwise this issue is just taking up space.

@Bill-Kunj
Copy link
Collaborator

So, let's discuss.
@dckc @jimscarver @w2vy

@jimscarver
Copy link
Contributor

i labeled this future. It is low priority at this time and should be here for future reference and potentially interested open source developers.

@Bill-Kunj Bill-Kunj added the rholang Stuff that involves rholang code label Jul 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
future rholang Stuff that involves rholang code
Projects
None yet
Development

No branches or pull requests

3 participants