Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reviewers please test: fix rholang location #254

Merged
merged 7 commits into from
Jul 22, 2021

Conversation

Bill-Kunj
Copy link
Collaborator

@Bill-Kunj Bill-Kunj commented Jul 21, 2021

Fixes 252: Tested and working on localhost

@Bill-Kunj Bill-Kunj added dev environment Anything affecting dev interface bootstrap Anything affecting bootstrap tooling rholang Stuff that involves rholang code labels Jul 21, 2021
@Bill-Kunj Bill-Kunj changed the title 252 fix rholang location Reviewers please test: fix rholang location Jul 21, 2021
@w2vy
Copy link
Collaborator

w2vy commented Jul 21, 2021

I was able to run bootstrap/deploy-all and all unit tests

@w2vy
Copy link
Collaborator

w2vy commented Jul 22, 2021

@Bill-Kunj Should I approve this and merge or do you want to wait for @jimscarver to review also?

Copy link
Contributor

@jimscarver jimscarver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok to me. if you prefer you can wait for my test or I can test after the pull

@jimscarver jimscarver merged commit 629dfe7 into master Jul 22, 2021
@jimscarver
Copy link
Contributor

this does not look good:

fatal: destination path 'rchain' already exists and is not an empty directory.

did a make install and start, working great.

@jimscarver jimscarver deleted the 252-fix-rholang-location branch July 22, 2021 12:54
@Bill-Kunj
Copy link
Collaborator Author

this does not look good:

fatal: destination path 'rchain' already exists and is not an empty directory.

did a make install and start, working great.

This message is covered under #253.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bootstrap Anything affecting bootstrap tooling dev environment Anything affecting dev interface rholang Stuff that involves rholang code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants