Skip to content
This repository was archived by the owner on Apr 1, 2025. It is now read-only.
This repository was archived by the owner on Apr 1, 2025. It is now read-only.

timer percentiles get stuck if update isn't called #215

Open
@newhook

Description

@newhook

I'm using a timer to record request latency percentiles. The problem is if there are no requests (meaning no calls to Update) the percentiles get "stuck" (meaning they latch on the last set of percentiles). Looking at the code this is because ExpDecaySample.update is the only thing that updates the samples (there is nothing that "ticks" the samples).

Is this deliberate?

I believe the java impl doesn't have this issue because the dataset is rescaled when fetched.

https://github.com/dropwizard/metrics/blob/4.0-development/metrics-core/src/main/java/com/codahale/metrics/ExponentiallyDecayingReservoir.java

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions