fix race #265
Merged
fix race #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for catching this, @zhanyr and @lechnertech. Would one of you mind adding a test that exercises this condition? We do run tests with |
|
done. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we got a race like this :
WARNING: DATA RACE
Read at 0x00c000249260 by goroutine 16:
gmessage-server/vendor/github.com/rcrowley/go-metrics.(*StandardRegistry).registered()
/home/work/buildspace/2d9632c8a4/.gopath/src/gmessage-server/vendor/github.com/rcrowley/go-metrics/registry.go:222 +0x91
gmessage-server/vendor/github.com/rcrowley/go-metrics.(*StandardRegistry).Each()
/home/work/buildspace/2d9632c8a4/.gopath/src/gmessage-server/vendor/github.com/rcrowley/go-metrics/registry.go:67 +0x3c
...
Previous write at 0x00c000249260 by goroutine 131:
runtime.mapassign_faststr()
/usr/local/go/src/runtime/map_faststr.go:190 +0x0
gmessage-server/vendor/github.com/rcrowley/go-metrics.(*StandardRegistry).register()
/home/work/buildspace/2d9632c8a4/.gopath/src/gmessage-server/vendor/github.com/rcrowley/go-metrics/registry.go:211 +0x113
gmessage-server/vendor/github.com/rcrowley/go-metrics.(*StandardRegistry).GetOrRegister()
/home/work/buildspace/2d9632c8a4/.gopath/src/gmessage-server/vendor/github.com/rcrowley/go-metrics/registry.go:103 +0x255
gmessage-server/vendor/github.com/rcrowley/go-metrics.GetOrRegisterTimer()
/home/work/buildspace/2d9632c8a4/.gopath/src/gmessage-server/vendor/github.com/rcrowley/go-metrics/timer.go:38 +0x77
...