Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8s changes for py-rcsb_app_chem #13

Open
wants to merge 100 commits into
base: master
Choose a base branch
from
Open

K8s changes for py-rcsb_app_chem #13

wants to merge 100 commits into from

Conversation

aditya-pingale
Copy link

The changes in this PR support the deployment of the py-rcsb_app_chem service into the Kubernetes environment. This PR will update the helm chart to our latest template, which includes integrating secrets deployments along with the chart, refactoring how values files are defined for each environment, and adding additional pod and container security context definitions to the deployments. It will also add in a new CI/CD pipeline to build and push images of the application to our internal harbor container image registry. This CI/CD pipeline will run in parallel with the existing buildlocker artifact process; once we completely migrate over to the Kubernetes environment, we'll clean up and remove the buildlocker pipeline in another PR.

@aditya-pingale aditya-pingale removed the request for review from henrychao-rcsb August 8, 2024 15:32
Copy link
Contributor

@henrychao-rcsb henrychao-rcsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Only minor suggestion I would have is in the values.yaml file, define the command list before the arguments list, as that would be the logical order of operations on how they would be used.

PR should be ready for developer review now.

@aditya-pingale
Copy link
Author

Hi @dmyersturnbull , We are preparing to merge our latest changes to enable the deployment of chemsearch service within the Kubernetes environment. This pull request will update the Helm chart to our latest template, incorporating secrets deployments, refining how values files are defined for each environment, and adding enhanced pod and container security contexts to the deployments. Additionally, it introduces a new CI/CD pipeline to build and push application images to our internal Harbor container registry.

Please let us know if you have any questions about this PR/change. Thanks!

…er publishing step since no longer using nexus (and new github actions workflow will push image to harbor)
@piehld
Copy link
Collaborator

piehld commented Aug 12, 2024

Hi @aditya-pingale and @henrychao-rcsb, I just created a separate PR for merging into this branch, which should address a number of the Azure issues. When possible, can you please take a look and merge that prior to merging this PR?

Here is the PR: #14

piehld and others added 2 commits August 13, 2024 11:35
@piehld
Copy link
Collaborator

piehld commented Aug 13, 2024

Thanks for the review @henrychao-rcsb. I also just made one other minor change (bumped Xcode), which I just pushed directly here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants