-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add option not to use pcrecpp #12
Conversation
intesting way of getting around this issue ;0) how about looking for liburiparser first, and then if that isn't found, falling back to using pcre? |
I'm not familiar with liburiparser, but it seems very stable library, it is supported from 12.04 to 15.04 My concern is I'm not confident this will get "exactly" same results as pcre provides, I have tested on test code, and it seems ok, but might be something that I missed. |
i think it is a great idea to use liburiparser. |
ping @rdiankov |
this can be resolved in ros/robot_model#108 ◉ Kei Okada On Fri, May 1, 2015 at 1:34 PM, Isaac I.Y. Saito notifications@github.com
|
oops, i thought i had merged this. thanks for the pull request! i just made a minor commit to fallback on pcrecpp |
thanks, merging this it's self is ok, but to be effective on ros users,
◉ Kei Okada On Sat, May 2, 2015 at 11:30 AM, Rosen Diankov notifications@github.com
|
I still have trouble on #7 and it seems something trouble if we load collada-dom vid dlopen and host program already have liked with pcre library
This PR rewrite function using pcrecpp, and confirmed it works on test code fixed in #11