fix(matter): Check for inbound cluster definitions#112
Merged
cleithner-comcast merged 1 commit intomainfrom Jan 9, 2026
Merged
fix(matter): Check for inbound cluster definitions#112cleithner-comcast merged 1 commit intomainfrom
cleithner-comcast merged 1 commit intomainfrom
Conversation
Previously we were referencing inbound clusters unconditionally, which could cause linker issues if the client did not specify those clusters in their cluster definition (zap or matter idl file). This commit adds preprocessor checks for these clusters using the generated gen_config.h header. Refs: BARTON-323
cleithner-comcast
requested review from
kfundecmcsa,
mkkoch and
tleacmcsa
as code owners
tleacmcsa
approved these changes
Jan 8, 2026
rchowdcmcsa
approved these changes
Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we were referencing inbound clusters unconditionally, which could cause linker issues if the client did not specify those clusters in their cluster definition (zap or matter idl file). This commit adds preprocessor checks for these clusters using the generated gen_config.h header.
Refs: BARTON-323