-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release - v2.11.0 #507
Merged
Merged
Release - v2.11.0 #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://lightningjs.io/docs/#/lightning-core-reference/Templates/Flexbox Documented as a possibility here to pull a flex item out of the tree.
The conditional is provable `if (true)`. `pos` starts at 0, and only increments in the for loop below bounded in iterations by `length`. Therefore, pos can never be greater than length.
Remove unnecessary conditional
Apply vertex specific color to the hole punch fragment
TextTextureRenderer: Fix word wrap behavior that regressed in 2.10.0
This fix solves an issue when the image worker is not being used, so Lightning processes images on the main thread. There is a simple check for `.png` to toggle whether or not the image has an alpha channel. This however gives an issue when a `.PNG` is used. Introduced a simple lowerCase cast to be able to work with both `.png` and `.PNG`. Additionally added some (quick and dirty) vitest cases to validate the above changes. Resolves: #493
Fix alpha channel detection when using in-process image handling.
Fix typo on renderOfScreen
Update typings of Element to allow flexItem: false
Revert "Fix typo on renderOfScreen"
Fix typo on renderOfScreen
Feature/pointer local coords
Adding support to create a context for webgl2.
uguraslan
requested review from
erikhaandrikman,
frank-weindel,
wouterlucas and
michielvandergeest
July 12, 2023 13:22
jfboeve
previously approved these changes
Jul 25, 2023
wouterlucas
previously approved these changes
Jul 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Is there a reason to not include this bug fix: #441 ? |
erikhaandrikman
dismissed stale reviews from wouterlucas and jfboeve
via
July 26, 2023 18:52
f3e791a
@jorge-graca-sky we still need to do regression tests on the fix, our plan is to ship it within the next release |
erikhaandrikman
approved these changes
Jul 27, 2023
michielvandergeest
approved these changes
Jul 27, 2023
wouterlucas
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
flexItem
can befalse
as referred to in the documentation. [Update typings of Element to allow flexItem: false #479 ]renderOffscreen
method ofElement
. [Fix typo on renderOfScreen #500 ]webgl2
as the fallback context option ifwebgl
orexperimental-webgl
is unavailable. [Enable to use webgl2 when webgl is not enabled in device. #496 ]Issues Fixed
PRs Included
Todo
package.json
andpackage-lock.json
CHANGELOG.md