Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release - v2.11.0 #507

Merged
merged 25 commits into from
Jul 28, 2023
Merged

Release - v2.11.0 #507

merged 25 commits into from
Jul 28, 2023

Conversation

uguraslan
Copy link
Contributor

@uguraslan uguraslan commented Jul 12, 2023

Changes

Issues Fixed

PRs Included

Todo

  • Update package.json and package-lock.json
  • Update CHANGELOG.md

itsjamie and others added 21 commits May 15, 2023 10:05
The conditional is provable `if (true)`.

`pos` starts at 0, and only increments in the for loop below bounded in iterations by `length`.

Therefore, pos can never be greater than length.
Remove unnecessary conditional
Apply vertex specific color to the hole punch fragment
TextTextureRenderer: Fix word wrap behavior that regressed in 2.10.0
This fix solves an issue when the image worker is not being used, so Lightning processes images on the main thread. There is a simple check for `.png` to toggle whether or not the image has an alpha channel. This however gives an issue when a `.PNG` is used. Introduced a simple lowerCase cast to be able to work with both `.png` and `.PNG`.

Additionally added some (quick and dirty) vitest cases to validate the above changes.
Resolves: #493
Fix alpha channel detection when using in-process image handling.
Update typings of Element to allow flexItem: false
Revert "Fix typo on renderOfScreen"
Adding support to create a context for webgl2.
@uguraslan uguraslan added this to the July 2023 release milestone Jul 12, 2023
@uguraslan uguraslan added the release This is a release PR label Jul 12, 2023
@uguraslan uguraslan marked this pull request as ready for review July 12, 2023 13:20
@uguraslan uguraslan requested a review from jfboeve July 12, 2023 13:22
jfboeve
jfboeve previously approved these changes Jul 25, 2023
wouterlucas
wouterlucas previously approved these changes Jul 26, 2023
Copy link
Contributor

@wouterlucas wouterlucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jorge-graca-sky
Copy link
Contributor

Is there a reason to not include this bug fix: #441 ?

@erikhaandrikman erikhaandrikman dismissed stale reviews from wouterlucas and jfboeve via f3e791a July 26, 2023 18:52
@erikhaandrikman
Copy link
Contributor

@jorge-graca-sky we still need to do regression tests on the fix, our plan is to ship it within the next release

@uguraslan uguraslan requested a review from jfboeve July 27, 2023 15:02
@uguraslan uguraslan merged commit 4a3ecc1 into master Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release This is a release PR
Projects
Status: Done
9 participants