Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cryptography] Add test key generator #226

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

sebaszm
Copy link
Contributor

@sebaszm sebaszm commented Sep 7, 2023

No description provided.

@sebaszm sebaszm requested a review from pwielders September 7, 2023 15:58

target_link_libraries(cgkeygen
PRIVATE
${NAMESPACE}Cryptography
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always like consistency :-) and my brain got an error by this construction :-D
Why do we always have ${NAMESPACE}Core::${NAMESPACE}Core and here only once (${NAMESPACE}Cryptography) without the semicolon. I understood from @bramoosterhuis that the first was the preferred way.
If so lets stick to that and always use for components that we as metrological deliver the ${NAMESPACE}Cryptography::${NAMESPACE}Cryptography to avoid my brain errors :-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Now need to educate myself on the difference. :)

@sebaszm sebaszm force-pushed the development/cg-test-keygen branch from 2b76393 to 0db71ed Compare September 11, 2023 09:05
@sebaszm sebaszm force-pushed the development/cg-test-keygen branch from 0db71ed to a0147d3 Compare September 11, 2023 09:05
@sebaszm sebaszm requested a review from pwielders September 11, 2023 09:06
@sebaszm sebaszm marked this pull request as draft September 13, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants