RDK-51273: Add IAnalytics interface #379
Conversation
adrianM27
force-pushed
the
master
branch
3 times, most recently
from
9aa4cdd to
d5455c3
Compare
| struct EXTERNAL IAnalytics : virtual public Core::IUnknown { | ||
| enum { ID = ID_ANALYTICS }; | ||
|
|
||
| virtual ~IAnalytics() override = default; |
There was a problem hiding this comment.
No need for virtual and override are mutual exclusive. Use one or the other. So just remove virtual here.
interfaces/IAnalytics.h
Outdated
| // @param uptimeTimestamp: Uptime timestamp of the event | ||
| // @param eventPayload: Payload of the event | ||
|
|
||
| virtual Core::hresult SendEvent(const string& eventName /* @in @text eventName*/, |
There was a problem hiding this comment.
You can define @text:keep on interface level, than you do not need to use the @text on all paramaters. Might be easier to maintain..
See https://rdkcentral.github.io/Thunder/plugin/interfaces/tags/
Snippit taken from there: "When used for a whole interface it must be used in the form '@text:keep'. It will in this case make the JSON generator use the name of the above items in JSON code exactly as specified in the interface, including the case of the text. Please note that of course the interface designer is responsible for making the interface compliant and consistent with the interface guideliness in use (even more perhaps then with the other uses of @text as now the whole interface is influenced). Please see an example on how to apply this form of @text below in the examples."
adrianM27
force-pushed
the
master
branch
4 times, most recently
from
7d918b7 to
85c9da6
Compare
|
Thank you @pwielders , I updated with requested changes |
interfaces/IAnalytics.h
Outdated
| struct EXTERNAL IAnalytics : virtual public Core::IUnknown { | ||
| enum { ID = ID_ANALYTICS }; | ||
|
|
||
| virtual ~IAnalytics() = default; |
There was a problem hiding this comment.
@adrianM27 one small remark ;-) As we are inheriting from Core::IUnknown, the destructor is already virtual. Using the override keyword the compiler will check that the base (destructor of Core::IUnknown) is virtual. Hence why I assumed you would drop the virtual keywrd and have the compiler check that the destructor of the base class is really virtual.
So suggest to state here: ~IAnalytics() override = default;
There was a problem hiding this comment.
Thanks @pwielders , updated
No description provided.