[WebKitBrowser] Update with JSON-RPC interface #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebaszm
previously approved these changes
Feb 7, 2025
pwielders
reviewed
Feb 10, 2025
pwielders
requested changes
Feb 10, 2025
|
@pwielders I just spoke about it with Sebastian, and we both agree that giving that much power and responsibility to the JavaScript user seems unwise.. On the side-note, I also noticed that right now this method allows to remove any directory by passing Since it was available in |
MFransen69
approved these changes
Feb 11, 2025
pwielders
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After merging this PR, we have to also merge this PR with changes to the plugin