Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IWifiControl] Changing params to Core::OptionalType #417

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[IWifiControl] Changing params to Core::OptionalType #417

wants to merge 2 commits into from

Conversation

nxtum
Copy link

@nxtum nxtum commented Feb 11, 2025 •
edited
Loading

Some options were made optional, if it did not make sense to include them for certain configurations.

Merge with:
rdkcentral/ThunderNanoServices#873

@nxtum nxtum mentioned this pull request Feb 11, 2025
Open
@nxtum nxtum requested a review from sebaszm February 11, 2025 13:28
sebaszm
sebaszm requested changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@sebaszm sebaszm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whenever there is a set of an optional field, first check if it's non empty (or not NONE for keys), so they indeed are optional on output as well. Only if they are unset they will be not serialized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebaszm sebaszm sebaszm requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nxtum @sebaszm