Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to Release_2016_03_4 #25

Merged
merged 1 commit into from
Aug 23, 2016
Merged

update to Release_2016_03_4 #25

merged 1 commit into from
Aug 23, 2016

Conversation

rvianello
Copy link
Contributor

updates the rdkit and rdkit-postgres* recipes to build the current patch release.

@greglandrum greglandrum merged commit 80c6334 into rdkit:master Aug 23, 2016
@rvianello
Copy link
Contributor Author

Thank you, I uploaded some up-to-date linux packages to the anaconda channel.

@greglandrum
Copy link
Member

Thanks Riccardo. I'll try to get a Mac package up soon too

@greglandrum
Copy link
Member

@rvianello : the linux builds were done without cairo support. Was this intentional or an oversight?

@rvianello
Copy link
Contributor Author

this is unexpected, the changes in the rdkit recipe are limited to the git tag. I'll look into this.

@greglandrum
Copy link
Member

I probably have confused myself. It may be that the linux builds never included cairo support for the C++ rendering code
Since we're including cairocffi as a build dependency (should also be a run dependency?), it seems like we assume that cairo will be on the system. If that's the case, couldn't we safely add -D RDK_BUILD_CAIRO_SUPPORT=ON to the build arguments?

@rvianello
Copy link
Contributor Author

cairo/cairocffi were not included as runtime dependencies just to avoid the mandatory installation of the graphics stack when not used, but on linux I think cairo may be safely assumed to be available, and yes, I agree it should be possible to add the RDK_BUILD_CAIRO_SUPPORT settings to the cmake command line. I will test this on a branch and then create a PR.

@rvianello rvianello deleted the update-to-Release_2016_03_4 branch July 19, 2017 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants