Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- added recipes for Windows PostgreSQL dependencies #52

Merged
merged 2 commits into from
Jul 7, 2017

Conversation

ptosco
Copy link
Contributor

@ptosco ptosco commented Jun 30, 2017

No description provided.

@greglandrum
Copy link
Member

Now it certainly attempts to build postgresql, which is a big step forward.
It doesn't actually work for me since it seems that the postgresql 9.4 windows build is looking for an older version of visual studio. This isn't horribly concerning to me since I don't think we particularly need to support every possible config.

I'll hold off on merging though until you have a chance to comment as to whether or not you think this is odd behavior.

@ptosco
Copy link
Contributor Author

ptosco commented Jun 30, 2017 via email

@ptosco
Copy link
Contributor Author

ptosco commented Jul 1, 2017

PostgreSQL <=9.5.2 won't build with VS2015. When I build 9.4.4 it worked for me as I have VS2013 and VS2015 on my Windows laptop and I hadn't even noticed that it had picked VS2013. I have added a patch such that PostgreSQL >=9.4 and <=9.5.2 builds with VS2015 and updated meta.yaml accordingly.

@greglandrum greglandrum merged commit 4047121 into rdkit:development Jul 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants