-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Numerous updates #56
Numerous updates #56
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the changes look good to me, I'll send you a message about the cartridge recipes, partly related to the status of the other pending PR.
RDBASE=$SRC_DIR LD_LIBRARY_PATH="$PREFIX/lib:$SRC_DIR/lib" PYTHONPATH=$SRC_DIR ctest -j$CPU_COUNT --output-on-failure | ||
RDBASE=$SRC_DIR LD_LIBRARY_PATH="$PREFIX/lib:$SRC_DIR/lib" PYTHONPATH=$SRC_DIR $PYTHON "$RECIPE_DIR/pkg_version.py" | ||
else | ||
make -j$CPU_COUNT install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this 'make install' in the osx branch looks a bit odd to me, I guess there's probably a reason for introducing it, but I'll comment anyway, just in case it's an oversight.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I put that in there when I was in the flailing "why the hell doesn't this work?" stage caused by the new conda python builds.
I'll try taking it out to see if things still work without it.
@rvianello : I think this is now mergeable as is. Once this is merged onto development, I think we should consider pushing it to master as well. |
@greglandrum thanks for the updates, and sorry for the slow feedback. the rdkit-postgresql95 recipe worked fine with the upstream 'postgresql' in my tests too, and I also agree that there should be little need for building the cartridge for the older versions (once the master is updated we could maybe consider removing some of these recipes that are no longer useful). |
Some of the changes here:
I've tested the full thing on the Mac and on CentOS6 with py36 (py35 seems to always be the same) and py27.
Most of this has also been tested on windows, but I will confirm that again.
I have not updated the other pieces, the cartridge build in particular, but that should also be done.