Refactor the tests for newer Phpunit version #201
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the nullable typehint PR, there's been a few commits to bump the PHP version, normalize test namespace and move towards github actions.
This PR attempts to update the testsuite to best accommodate these changes, though I have made some judgement calls:
I've went as far as I could with solving the tests, however on 8.x suites there are a few failures that necessitate a better knowedge of what should happen than I possess (please see https://github.com/Zvax/auryn/actions/runs/12017589097). I think they are related, it seems like the nullable instances with default values aren't being passed, or something.
As far as I can teel this seems like the behaviour actually changes so I don't know what should be changed.
Please let me know if/how these should be fixed.