Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit autoupdate CI job #777

Closed
afuetterer opened this issue Oct 13, 2023 · 2 comments · Fixed by #789
Closed

Add pre-commit autoupdate CI job #777

afuetterer opened this issue Oct 13, 2023 · 2 comments · Fixed by #789

Comments

@afuetterer
Copy link
Member

Rationale / Begründung

I propose adding a CI job, that runs using a cron job (once per month like the dependabot?), and updates the pre-commit hooks config. What do you think?

Affected

devs

Minimal functionality

The job should run

pre-commit autoupdate

check, if the .pre-commit-config.yaml changed, if yes, commit it and create a PR.

https://pre-commit.ci/ does this automatically, but I guess we don't need another service involved.

References / Verweise

@jochenklar
Copy link
Member

Good idea! I would also be fine with the pre-commit service, but I should only create PR to update-dependencies or somethin similar which we then merge into dev-*.

@afuetterer
Copy link
Member Author

afuetterer commented Oct 16, 2023

I could provide a custom GitHub action for rdmo.

But if you prefer, we can use https://pre-commit.ci/ as well. I have not used it before, but a lot of projects use it, it is from the author of pre-commit itself. They can do the linting for us as well then. They say it is really fast.

See: https://pre-commit.ci/#configuration

@afuetterer afuetterer self-assigned this Oct 19, 2023
afuetterer added a commit to afuetterer/rdmo that referenced this issue Oct 20, 2023
@afuetterer afuetterer linked a pull request Oct 20, 2023 that will close this issue
11 tasks
afuetterer added a commit to afuetterer/rdmo that referenced this issue Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants