Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: update pre-commit hooks #1166

Merged
merged 6 commits into from
Oct 11, 2024
Merged

build: update pre-commit hooks #1166

merged 6 commits into from
Oct 11, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 1, 2024

Proposed changes

Bumps the pre-commit config with the following updates:

This PR is auto-generated once a month.

Note

Mark this PR as ready for review to trigger additional checks.

@github-actions github-actions bot force-pushed the pre-commit-autoupdate branch from af5235d to 1c7e094 Compare October 1, 2024 01:13
@github-actions github-actions bot added dependencies Pull requests that update a dependency file pre-commit type:maintenance labels Oct 1, 2024
MyPyDavid
MyPyDavid reviewed Oct 11, 2024
View reviewed changes
README.md Show resolved Hide resolved
@MyPyDavid MyPyDavid marked this pull request as ready for review October 11, 2024 10:07
@MyPyDavid MyPyDavid requested a review from afuetterer October 11, 2024 10:07
@MyPyDavid MyPyDavid mentioned this pull request Oct 11, 2024
Closed
@MyPyDavid MyPyDavid linked an issue Oct 11, 2024 that may be closed by this pull request
Proposal: Switch to pre-commit.ci service instead of custom pre-commit jobs #1091
Closed
@MyPyDavid MyPyDavid mentioned this pull request Oct 11, 2024
Closed
@afuetterer
Copy link
Member

Thanks for picking this up.

@MyPyDavid
Copy link
Member

Thank you! This pre-commit-autoupdate.yml workflow can then also be deleted right?

@afuetterer
Copy link
Member

Thank you! This pre-commit-autoupdate.yml workflow can then also be deleted right?

Yes, it is replaced by pre-commit.ci.
Actually the run condition of the ci workflow can be adapted again as well. Let me check.

@afuetterer

This comment was marked as resolved.

Sign in to view
github-actions bot and others added 5 commits October 11, 2024 17:06
@github-actions @MyPyDavid
build: update pre-commit hooks
38db5dd
@MyPyDavid
build(pre-commit): autoupdate hooks and update eslint-plugin-react
a78467b 
Signed-off-by: David Wallace <david.wallace@tu-darmstadt.de>
@MyPyDavid
build(pre-commit): add pre-commit.ci config
a2ecba8 
Signed-off-by: David Wallace <david.wallace@tu-darmstadt.de>
@MyPyDavid
docs: add pre-commit.ci badge to README.md
7714e1d 
Signed-off-by: David Wallace <david.wallace@tu-darmstadt.de>
@MyPyDavid
build(pre-commit): add commit msg to autoupdate config
0da46cc 
Signed-off-by: David Wallace <david.wallace@tu-darmstadt.de>
@MyPyDavid MyPyDavid force-pushed the pre-commit-autoupdate branch from e1d8c77 to bd2be20 Compare October 11, 2024 15:09
@MyPyDavid
ci: remove pre-commit-autoupdate workflow and related types array
2283088 
Signed-off-by: David Wallace <david.wallace@tu-darmstadt.de>

# Conflicts:
#	.github/workflows/pre-commit-autoupdate.yml
@MyPyDavid MyPyDavid force-pushed the pre-commit-autoupdate branch from bd2be20 to 2283088 Compare October 11, 2024 15:12
@MyPyDavid
Copy link
Member

alright, thanks, Ive deleted those types as well.
I needed to rebase but now it looks done right?

@afuetterer
Copy link
Member

Yes, I think this is all.

@MyPyDavid MyPyDavid merged commit c6cfe9c into dependency-updates Oct 11, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MyPyDavid MyPyDavid MyPyDavid left review comments

@afuetterer afuetterer afuetterer approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file pre-commit type:maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proposal: Switch to pre-commit.ci service instead of custom pre-commit jobs
2 participants
@afuetterer @MyPyDavid