Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre commit ci add config to main #1172

Merged
merged 6 commits into from
Oct 18, 2024
Merged

Pre commit ci add config to main #1172

merged 6 commits into from
Oct 18, 2024

Conversation

MyPyDavid
Copy link
Member

@MyPyDavid MyPyDavid commented Oct 18, 2024 •
edited
Loading

Description

Add the pre-commit.ci config to the main branch and removes the previous custom autoupdate workflow.

Motivation and Context

How has this been tested?

Screenshots (if appropriate)

github-actions bot and others added 6 commits October 18, 2024 09:26
@github-actions @MyPyDavid
build: update pre-commit hooks
8814c17
@MyPyDavid
build(pre-commit): autoupdate hooks and update eslint-plugin-react
16c044b 
Signed-off-by: David Wallace <david.wallace@tu-darmstadt.de>
@MyPyDavid
build(pre-commit): add pre-commit.ci config
4b84e85 
Signed-off-by: David Wallace <david.wallace@tu-darmstadt.de>
@MyPyDavid
docs: add pre-commit.ci badge to README.md
87b9bc7 
Signed-off-by: David Wallace <david.wallace@tu-darmstadt.de>
@MyPyDavid
build(pre-commit): add commit msg to autoupdate config
69fbb3c 
Signed-off-by: David Wallace <david.wallace@tu-darmstadt.de>
@MyPyDavid
ci: remove pre-commit-autoupdate workflow and related types array
efbd297 
Signed-off-by: David Wallace <david.wallace@tu-darmstadt.de>
@MyPyDavid MyPyDavid changed the title Pre commit ci add config Pre commit ci add config to main Oct 18, 2024
@MyPyDavid MyPyDavid mentioned this pull request Oct 18, 2024
Closed
@coveralls
Copy link

Coverage Status

coverage: 90.478%. remained the same
when pulling efbd297 on pre-commit-ci-add-config
into 1cdcf9e on main.

@MyPyDavid MyPyDavid self-assigned this Oct 18, 2024
@MyPyDavid MyPyDavid requested a review from jochenklar October 18, 2024 08:14
jochenklar
jochenklar approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@jochenklar jochenklar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just for the CI, right? I want to merge 2.2.2 today anyway, so maybe we merge this first.

@MyPyDavid
Copy link
Member Author

yes it is just for ci, I think this one 16c044b might give a conflict with the current 2.2.2 but a simple rebase should fix it.

@jochenklar
Copy link
Member

Just merge it to main, and we merge 2.2.2 later today.

@MyPyDavid MyPyDavid merged commit abfee20 into main Oct 18, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afuetterer afuetterer afuetterer approved these changes

@jochenklar jochenklar jochenklar approved these changes

Assignees

@MyPyDavid MyPyDavid

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MyPyDavid @coveralls @jochenklar @afuetterer