Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix grammar #765

Merged
merged 4 commits into from
Nov 24, 2023
Merged

Fix grammar #765

merged 4 commits into from
Nov 24, 2023

Conversation

jochenklar
Copy link
Member

Description

This PR refactors the automatically generated help text in the interview (for question, question set and page collections). It removes the faulty combination of verbose_name and verbose_name_plural (from the model) with the translated text and adds generic formulations. It also remove verbose_name_plural from Question, QuestionSet and Page since it is not needed anymore.

Related issue: #59, #602, #703

@MyPyDavid
Copy link
Member

so that part verbose_name_plural could (eventually) be removed from the catalogs that use it (ref: https://github.com/search?q=repo%3Ardmorganiser%2Frdmo-catalog%20verbose_name_plural&type=code)?

@jochenklar
Copy link
Member Author

yes. It will drop from all instances with migrate and then ignored during import. Less stress for those who develop catalogs.

@MyPyDavid MyPyDavid added this to the 2.1.0 milestone Oct 6, 2023
@jochenklar jochenklar self-assigned this Oct 10, 2023
@jochenklar jochenklar requested a review from MyPyDavid October 27, 2023 14:33
@jochenklar jochenklar added the migrations Indicates that this PR contains migrations label Nov 19, 2023
MyPyDavid
MyPyDavid approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@MyPyDavid MyPyDavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests, fixtures, translations and migrations!

@jochenklar jochenklar merged commit 749f45e into dev-2.1.0 Nov 24, 2023
13 checks passed
@jochenklar jochenklar deleted the fix_grammar branch December 12, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MyPyDavid MyPyDavid MyPyDavid approved these changes

Assignees

@jochenklar jochenklar

Labels
migrations Indicates that this PR contains migrations status:agreed
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jochenklar @MyPyDavid