-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add official support for python 3.12 #768
Conversation
so when all the tests pass, it means that all the dependencies are compatible with 3.12 as well? and we don't need to test for 3.11 anymore? |
We can still test for 3.11 of course, I just followed your approach of testing the min and max versions of Python. All tests are passing, so they are a) installable with Python 3.12, also optional dependencies and b) rdmo still works as expected. |
We can use |
no thanks, think that the min max is also a good approach! |
We tested for all versions before, but I think testing the min/max versions should be ok. I would guess that things break if we use to new features in an old version, or if features we use are changed in a new version. Both cases should be covered with only the minimum maximum version. |
I did not choose this approach, it was already in place. Yes, I think that is correct. If we use bleeding edge Python 3.12 features, the tests for 3.8 will fail. In my opinion that is enough of a safety net. But sure, lots of projects test with 3.8, 3.9, 3.10, 3.11, 3.12. And then also for Windows, Mac and Linux. That is overkill for a project like rdmo in my opinion. But a library like requests, that is used all over the place should have such testing. What do you think? Go for the merge then? |
chore: add official support for python 3.12
Description
Related issue: #704
Types of Changes
Checklist