Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add official support for python 3.12 #768

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

afuetterer
Copy link
Member

Description

Related issue: #704

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Checklist

  • I have read the contributor guide.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@afuetterer afuetterer linked an issue Oct 3, 2023 that may be closed by this pull request
4 tasks
@MyPyDavid
Copy link
Member

so when all the tests pass, it means that all the dependencies are compatible with 3.12 as well? and we don't need to test for 3.11 anymore?

@afuetterer
Copy link
Member Author

We can still test for 3.11 of course, I just followed your approach of testing the min and max versions of Python.

All tests are passing, so they are a) installable with Python 3.12, also optional dependencies and b) rdmo still works as expected.

@afuetterer
Copy link
Member Author

We can use python-version: ['3.8', '3.11', '3.12'], if you prefer.

@MyPyDavid
Copy link
Member

no thanks, think that the min max is also a good approach!

@jochenklar
Copy link
Member

We tested for all versions before, but I think testing the min/max versions should be ok. I would guess that things break if we use to new features in an old version, or if features we use are changed in a new version. Both cases should be covered with only the minimum maximum version.

@afuetterer
Copy link
Member Author

I did not choose this approach, it was already in place.
See e.g. 322d0a6

Yes, I think that is correct. If we use bleeding edge Python 3.12 features, the tests for 3.8 will fail. In my opinion that is enough of a safety net. But sure, lots of projects test with 3.8, 3.9, 3.10, 3.11, 3.12. And then also for Windows, Mac and Linux. That is overkill for a project like rdmo in my opinion. But a library like requests, that is used all over the place should have such testing.

What do you think? Go for the merge then?

@afuetterer afuetterer merged commit 5c0a76e into rdmorganiser:dev-2.0.1 Oct 4, 2023
@afuetterer afuetterer deleted the 704-python-312 branch October 4, 2023 10:10
CalamityC pushed a commit to CalamityC/rdmo that referenced this pull request Nov 23, 2023
chore: add official support for python 3.12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add official support for Python 3.12
3 participants