Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: pin django-mptt dependency #786

Merged
merged 1 commit into from
Oct 20, 2023
Merged

build: pin django-mptt dependency #786

merged 1 commit into from
Oct 20, 2023

Conversation

afuetterer
Copy link
Member

@afuetterer afuetterer commented Oct 17, 2023 •
edited
Loading

Description

This PR proposes the following changes:

  • pin django-mptt dependency to 0.14.0, because the next minor version (0.15) requires Python >= 3.9
  • set dependabot config to ignore updates for django-mptt

These settings should be relaxed once RDMO requires Python >= 3.9 as well, so potentially a year from now, when Python 3.8 reaches EOL.

This PR supersedes #753.

Types of Changes

  • Build related changes

Checklist

  • I have read the contributor guide.
  • My code follows the code style of this project.
  • All new and existing tests passed.

@afuetterer afuetterer changed the base branch from master to dev-2.1.0 October 17, 2023 04:41
@jochenklar
Copy link
Member

Thanks! Pretty weird that the project is unmaintained, but creates new breaking releases. See also: #368.

@afuetterer
Copy link
Member Author

Yes, totally weird. The poor maintainer sounds really frustrated.

@afuetterer afuetterer changed the title chore: pin django-mptt dependency build: pin django-mptt dependency Oct 20, 2023
@afuetterer
Copy link
Member Author

Okay for you as well @MyPyDavid? Then I'll merge.

MyPyDavid
MyPyDavid approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@MyPyDavid MyPyDavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes for pinned, thanks!

@afuetterer afuetterer merged commit bad2984 into rdmorganiser:dev-2.1.0 Oct 20, 2023
12 checks passed
@afuetterer afuetterer deleted the django-mptt branch October 20, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MyPyDavid MyPyDavid MyPyDavid approved these changes

@jochenklar jochenklar jochenklar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@afuetterer @jochenklar @MyPyDavid