Add support for Voron v0.2 #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Voron 0.2 skirts have a different size honeycomb pattern and are thicker than the original v0 skirts. These STLs have been adjusted to account for both changes.
Add STLs for the Voron 0.2
Updated the scad to enable cration of both v0.2 and older v0 serial plates.
cdheiser
added a commit
to cdheiser/voron_nameplate_bot
that referenced
this pull request
Apr 9, 2023
New defaults in the scad will only generate v0.2 serial plates. This change continues to generate legacy serial plates. This should be merged in and pushed after rdmullett/voron_serial_plate#5 is merged in.
|
@cdheiser thanks for the PRs, I'm traveling this week and next, so I'll have to review them when I have some more time. Hopefully late next week. |
|
@cdheiser Sorry for the delay, got a bit busy. I have a few things on this.
|
Open
|
On Mon, May 15, 2023 at 10:13 AM Ryan Mullett ***@***.***> wrote:
@cdheiser <https://github.com/cdheiser> Sorry for the delay, got a bit
busy. I have a few things on this.
1. How do we know when it's a v0.2? Is there any indication within the
serial number?
There is no indication.
1. Is this backwards compatible with original v0 skirts? If so, we
could just provide this to every v0 from now on
No unfortunately, the spacing and depth are different enough for this to
be just a touch obnoxious.
1. There's a new PR #6
<#6> that actually
gets rid of the static STL files entirely, so I think we may end up
skipping this, but instead getting the files that you've referenced here
included into the parameterized version of the scad files.
HAH! It wouldn't be hard to build a PR based off that one. I have the
delta measurements around here in the cad somewhere.
…
—
Reply to this email directly, view it on GitHub
<#5 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACQARWVD76HVESKVYO3BKX3XGJP3BANCNFSM6AAAAAAWYJHSKA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The v0.2 has different skirts than the previous generations which do not work with the current v0 skirts. This PR adds updated STLs for the v0.2 and options in the SCAD to use older or newer serial plates.