Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow empty env.config in config yaml file #90

Closed
rdnfn opened this issue Jul 15, 2022 · 1 comment
Closed

Allow empty env.config in config yaml file #90

rdnfn opened this issue Jul 15, 2022 · 1 comment
Labels
bug Something isn't working concerns: main API
Milestone

Comments

@rdnfn
Copy link
Owner

rdnfn commented Jul 15, 2022

Problem

There can be issues with setting env.config to None/null in a config file or leaving out this setting entirely. This is because some parts of the scheduler assume a non-empty env.config. This issue was originally raised in #82 by @HYDesmondLiu.

Potential Solution

There are multiple ways to achieve this:

  1. automatically add env config if empty (requires access to this in code).
  2. remove call to config outside env_creator script.
@rdnfn rdnfn added bug Something isn't working concerns: main API labels Jul 15, 2022
@rdnfn rdnfn added this to the v0.6.0 milestone Jul 15, 2022
rdnfn added a commit that referenced this issue Sep 16, 2022
@rdnfn
Copy link
Owner Author

rdnfn commented Sep 16, 2022

On the current dev version, the name attribute is no longer required anywhere in Beobench scheduler or agent code. Thus, this issue will be resolved in the next release.

@rdnfn rdnfn closed this as completed Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working concerns: main API
Projects
None yet
Development

No branches or pull requests

1 participant