Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rakefile Best Practices (& RuboCop) #72

Merged
merged 10 commits into from
Dec 15, 2022
Merged

Conversation

pboling
Copy link
Collaborator

@pboling pboling commented Dec 11, 2022

Stops requiring rubygems from within the rubygem.

Uses my rubocop-lts which includes pre-set definitions to ensure compatibility with Ruby 1.8 syntax.

inherit_gem:
  rubocop-lts: rubocop-lts1_8.yml

Result, after auto-correcting, manually fixing a few, and putting the rest into "todo":

Running RuboCop...
Inspecting 10 files
..........

10 files inspected, no offenses detected

Sits on top of #71

Fixes #64

🚑️ Remove circular dependency; Fix specs
Signed-off-by: Peter Boling <peter.boling@gmail.com>
- Upgrade to rake 10.5
- Upgrade to bundler 2.3
- Upgrade RSpec test syntax with transpec
➕ Switch from autotest to guard-rspec
- Stop requiring rubygems
This was referenced Dec 11, 2022
@pboling pboling merged commit 9fca0ce into rdp:master Dec 15, 2022
@pboling pboling deleted the bug/64-rakefile-bp branch December 15, 2022 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rakefile best practices; Stop requiring rubygems
1 participant