Do not validate unknown filters #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dn-readytech
approved these changes
Mar 25, 2021
|
It would be good to display a warning that some of the filters have been removed. This is to prevent users from blindly relying on bookmarked urls and expecting correct results when in fact the results could be different because some of the filters are no longer available on the page. |
|
@andrba It shouldn't affect them. Any bookmarked urls that include an unknown filter currently wipe the query params resulting in no filters being applied and hence unfiltered results. This change allows unknown filters to be ignored so that a request with all valid filters can be applied. This PR does not change the behaviour where there is an invalid filter in the params. It will still wipe the query params and return unfiltered results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently all filter params in the query are validated against the filters available on the page. If you reference an unknown filter, the entire query is dropped and you get no filters at all. This PR changes that behaviour so that unknown filters are now no longer validated and are merely ignored.