Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] lack of namespace in fivetran_utils macros #103

Closed
bachng2017 opened this issue Oct 29, 2022 · 0 comments
Closed

[BUG] lack of namespace in fivetran_utils macros #103

bachng2017 opened this issue Oct 29, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@bachng2017
Copy link
Contributor

Describe the bug
percentile and json_extract macros lack of namespace, so they could not be extended (for example by dbt_re_data_trino)

Expected behavior
namespace is evaluated correctly in dbt_project.yml

To Reproduce
current codes from github
https://github.com/re-data/dbt-re-data/blob/main/macros/utils/fivetran_utils/percentile.sql#L8
https://github.com/re-data/dbt-re-data/blob/main/macros/utils/fivetran_utils/json_extract.sql#L8
@bachng2017 bachng2017 added the bug Something isn't working label Oct 29, 2022
@bachng2017 bachng2017 changed the title [BUG] [BUG] lack of namespace in fivetran_utils macros Oct 29, 2022
akshaykarle pushed a commit to akshaykarle/dbt-re-data that referenced this issue Nov 2, 2022
@bachng2017 @akshaykarle
add namespace to fivetran_utils macros, fix re-data#103 (re-data#104)
865bb12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bachng2017