Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to React 19 #321

Merged
merged 8 commits into from
Jan 14, 2025
Merged

Update to React 19 #321

merged 8 commits into from
Jan 14, 2025

Conversation

rveciana
Copy link
Contributor

@rveciana rveciana commented Jan 9, 2025

Upgrade the dependencies for the project
Fix broken tests because of the vitest upgrade
Fix small errors because of the react upgrade

Copy link
Collaborator

@voliva voliva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rveciana for the contribution!

I see you have updated the devDependencies of the monorepo, but the @react-rxjs/core pacakge is left untouched, aside from linting/prettier changes.

I think we have to update the peerDependency of @react-rxjs/core to declare it's compatible with react@19

packages/core/src/bind/connectFactoryObservable.test.tsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@voliva voliva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @rveciana!

It looks good to me, but you have removed some generics on the test files that gives me TS errors on my IDE - I tried adding a commit fixing those to this PR but I couldn't, you can cherry-pick it if you want: 6923301

The CI is failing for an unrelated issue with some code coverage tool we have, I'll take a look as a separate issue.

@rveciana
Copy link
Contributor Author

rveciana commented Jan 14, 2025

Thanks for finding this. A wrong vscode configuration did it.

@voliva
Copy link
Collaborator

voliva commented Jan 14, 2025

@all-contributors please add @rveciana for maintenance

Copy link
Contributor

@voliva

I've put up a pull request to add @rveciana! 🎉

@voliva voliva merged commit 22e5866 into re-rxjs:main Jan 14, 2025
1 check failed
@voliva
Copy link
Collaborator

voliva commented Jan 14, 2025

Published as @react-rxjs/core@0.10.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants