-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to React 19 #321
Update to React 19 #321
Conversation
Upgrade to react 19
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rveciana for the contribution!
I see you have updated the devDependencies
of the monorepo, but the @react-rxjs/core
pacakge is left untouched, aside from linting/prettier changes.
I think we have to update the peerDependency of @react-rxjs/core
to declare it's compatible with react@19
…sync-external-store
Change waitFor timeout and remove uneeded waitFor usage. Upgrade use-…
sync cpackage-lock.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again @rveciana!
It looks good to me, but you have removed some generics on the test files that gives me TS errors on my IDE - I tried adding a commit fixing those to this PR but I couldn't, you can cherry-pick it if you want: 6923301
The CI is failing for an unrelated issue with some code coverage tool we have, I'll take a look as a separate issue.
Add removed types again
Thanks for finding this. A wrong vscode configuration did it. |
@all-contributors please add @rveciana for maintenance |
I've put up a pull request to add @rveciana! 🎉 |
Published as @react-rxjs/core@0.10.8 |
Upgrade the dependencies for the project
Fix broken tests because of the vitest upgrade
Fix small errors because of the react upgrade