Replace deprecated methods #314
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NameNotFinal
commented
Mar 10, 2022
Comment on lines
50
to
54
| public static triggerVueEvent(element: JQuery<HTMLElement>, name: string, label?: string): void { | ||
| const e = document.createEvent('HTMLEvents'); | ||
| e.initEvent(name, true, true); | ||
| const e = new Event(name, { "bubbles": true, "cancelable": true }); | ||
| if (label) element.data(label, "true"); | ||
| element[0].dispatchEvent(e); | ||
| } |
There was a problem hiding this comment.
I haven't been able to verify that this works cause I wasn't able to find any good way of testing this, however it doesn't seem to break anything (and this way of handling events works in reloadButtonToolbar)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once again while working on another feature I noticed some deprecated functions in use, and while they probably all work just fine, I thought it might be a good idea to replace them before they become completely obsolete.
This PR addresses these deprecations:
Other stuff:
It also contains a little adjustment to add a notice when you press "Copy ID" on comments/forum posts.
Note: I haven't been able to find a good replacement for execCommand("insertText") as used here https://github.com/bitWolfy/re621/blob/eddef40ac5e607481d6e1e588cf3dcf610fd1a54/src/js/modules/general/FormattingExtender.ts#L188-L192
I'll undraft this once I manage to implement that, or decide to leave it